Unsquash rust-lang/rust-bindgen#1793 for personal review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A macro expansion could contain a string constant, which might not be UTF-8. Also, using `&[u8]` for the expansion keeps the new API closer to the precedent set by `str_macro`.
If we cannot reproduce the original whitespace anyway, then we should let the callee decide what to do with the tokens, rather than smashing them together in a "safe" way.
Also switch to an explicit version check in `parse_macro`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never-to-be-merged PR shows the pre-squash version of what became rust-lang#1793.
The tip of this PR is identical (except for a comment change) to rust-lang@d2e0407.